Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a router configuration option to reject requests without tracing data #341

Open
klingerf opened this issue Apr 27, 2016 · 1 comment

Comments

@klingerf
Copy link
Member

This suggestion came up in conversation with @harryzoomed. Right now when linkerd receives an http request that does not include a trace id, it initializes a new trace for the request:

https://github.com/BuoyantIO/linkerd/blob/master/linkerd/protocol/http/src/main/scala/com/twitter/finagle/buoyant/linkerd/HttpTraceInitializer.scala#L28

That is the correct behavior for when a request first enters the system. For additional downstream requests, however, we expect requests to already have their trace id set, and not having a trace id might be an indication that the request was mishandled by an upstream service. In that case, it could be helpful to expose a router configuration option, such that we could configure an internal router to reject requests that are missing their tracing data.

@olix0r
Copy link
Member

olix0r commented Sep 12, 2016

At the least, I think we could expose a counter that tracks the number of newly-minted trace ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants