Ensure BufferingChannelTransport flushing task does not block event loop #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent loop Fixes linkerd#2398 Signed-off-by: Henri Hagberg <[email protected]>
2 tasks
|
Thanks @hmhagberg! My main concern here is that I wonder if this makes it possible for items to become stuck in the writeQueue and not get flushed out until the next write occurs. |
|
I don't think that is an issue. At the end of so a new task is immediately scheduled if there are unwritten items. The main difference here is that if anything else was added to event loop queue (like ping task) that will be executed first before flushing is continued. |
|
Closing this in favor of the workaround specified in #2398 Set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If data is written to
BufferingChannelTransportqueue faster than it can be flushed, the flushing task can take arbitrarily long to complete. This prevents any other queued task from running.This patch ensures that a new task is created when
MaxFlushSize(currently 128) messages are flushed so other queued tasks are executed sooner.Fixes #2398
Signed-off-by: Henri Hagberg [email protected]