Remove ZK candidate dep #2361
Merged
Remove ZK candidate dep #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
adleong
reviewed
Dec 6, 2019
| @@ -0,0 +1,728 @@ | |||
| // ================================================================================================= | |||
There was a problem hiding this comment.
| @@ -0,0 +1,518 @@ | |||
| // ================================================================================================= | |||
There was a problem hiding this comment.
| @@ -0,0 +1,168 @@ | |||
| // ================================================================================================= | |||
There was a problem hiding this comment.
project/Deps.scala
Outdated
| @@ -13,6 +13,11 @@ object Deps { | |||
|
|
|||
| def twitterUtil(mod: String) = | |||
| "com.twitter" %% s"util-$mod" % "19.5.1" | |||
|
|
|||
| def twitterCommonUtil = "com.twitter.common" % "util" % "0.0.121" | |||
There was a problem hiding this comment.
I think the goal here is to stop depending on com.twitter.common altogether. I think this means we also need to copy things like com.twitter.common.base.Command into our repo if they haven't already been copied into finagle-serversets
project/Deps.scala
Outdated
| def zkCandidate = | ||
| ("com.twitter.common.zookeeper" % "candidate" % "0.0.84") | ||
| .exclude("com.twitter.common", "util") | ||
| def apacheZookeeper = ("org.apache.zookeeper" % "zookeeper" % "3.5.0-alpha") |
There was a problem hiding this comment.
I think if we depend on finalge-serversets, we should automatically get this as a transitive dependency.
Signed-off-by: Zahari Dichev <[email protected]>
807a25f
to
c61fd7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact for com.twitter.common.zookeeper" % "candidate" % "0.0.84" on maven.twttr.com is not present anymore. Therefore we need to cpy the bits that we use from it and have it in our sourcecode.
Fixes #2360
Signed-off-by: Zahari Dichev [email protected]