Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a service configuration option to set the HTTP URI from the residual path #1602

Open
olix0r opened this issue Aug 21, 2017 · 3 comments
Open

Comments

@olix0r
Copy link
Member

olix0r commented Aug 21, 2017

For example, a request like:

GET /book HTTP/1.1

Would be sent as:

GET /api/published
content-length: 0
l5d-dst-service: /svc/book
Via: 1.0 linkerd
l5d-dst-client: /$/inet/10.0.0.2/8080
l5d-dst-residual: /api/published

Because this has to occur after retries, we should be careful to only ever set (and not modify) the request's URI. Otherwise, we have to take care to preserve the original URI across retries.

@olix0r olix0r changed the title Add a _service_ configuration option to set the HTTP URI from the residual path Add a service configuration option to set the HTTP URI from the residual path Aug 21, 2017
@klingerf
Copy link
Member

I'm not sure I follow this. Should the example request be GET /book/api/published HTTP/1.1? Instead of GET /book HTTP/1.1?

@olix0r
Copy link
Member Author

olix0r commented Aug 21, 2017

sorry, assume a dtab rule like /svc/book => /$/inet/10.0.0.2/8080/api/published

@klingerf
Copy link
Member

Ahhh, ok, makes sense. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants