-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move finagle and grpc projects to a dedicated repo #1588
Comments
any update on this @olix0r ? |
Any update here @olix0r ? Novolabs is more than willing to allocate some development cycles to help in any way we can with this. |
Sorry for the radio silence on our end. We've been focused on a number of issues that touch finagle-h2, and moving this subproject out of this repo would add significant friction to our debug cycle... I am not against this change in general, though I think it is ill-advised to do this before these features are considered stable in linkerd. |
any update here? What about a module inside this repo so you don't need to move anything and still build normally (just a separate subproject)? |
actually, maybe you already did this? |
The finagle-h2 and grpc projects are already sbt subprojects in the Linkerd repo that can be built individually. @oscar-stripe is that sufficient or are you still interested in them being moved into a separate repo? |
finagle
andgrpc
subprojects. The finagle project houses our h2 implementation and the grpc project has the protoc plugin, runtime library (that depends on the h2 impl, etc).The text was updated successfully, but these errors were encountered: