Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move finagle and grpc projects to a dedicated repo #1588

Open
3 tasks
olix0r opened this issue Aug 15, 2017 · 6 comments
Open
3 tasks

Move finagle and grpc projects to a dedicated repo #1588

olix0r opened this issue Aug 15, 2017 · 6 comments

Comments

@olix0r
Copy link
Member

olix0r commented Aug 15, 2017

  • create a new repo with copies of linkerd's finagle and grpc subprojects. The finagle project houses our h2 implementation and the grpc project has the protoc plugin, runtime library (that depends on the h2 impl, etc).
  • We'll probably need help putting together an SBT plugin.
  • Once we can publish all of this from the new repo, we'll update the linkerd repo to depend on these libraries.
@johnynek
Copy link

any update on this @olix0r ?

@penland365
Copy link

Any update here @olix0r ? Novolabs is more than willing to allocate some development cycles to help in any way we can with this.

@olix0r
Copy link
Member Author

olix0r commented Nov 16, 2017

Sorry for the radio silence on our end. We've been focused on a number of issues that touch finagle-h2, and moving this subproject out of this repo would add significant friction to our debug cycle...

I am not against this change in general, though I think it is ill-advised to do this before these features are considered stable in linkerd.

@oscar-stripe
Copy link

any update here? What about a module inside this repo so you don't need to move anything and still build normally (just a separate subproject)?

@oscar-stripe
Copy link

actually, maybe you already did this?

@adleong
Copy link
Member

adleong commented May 31, 2018

The finagle-h2 and grpc projects are already sbt subprojects in the Linkerd repo that can be built individually. @oscar-stripe is that sufficient or are you still interested in them being moved into a separate repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants