Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to build.sbt #1564

Open
hawkw opened this issue Aug 4, 2017 · 2 comments
Open

Migrate to build.sbt #1564

hawkw opened this issue Aug 4, 2017 · 2 comments

Comments

@hawkw
Copy link
Member

hawkw commented Aug 4, 2017

According to the sbt documentation,

sbt 0.13’s introduction of multi-project build.sbt made the Build trait redundant. In addition, the auto plugin feature that’s now standard in sbt 0.13 enabled automatic sorting of plugin settings and auto import feature, but it made Build.scala more difficult to maintain.

In sbt 0.13.13, using the Build trait for build definitions has been deprecated, and it will be removed when sbt 1.0 is released. Therefore, we will want to move to using a build.sbt-based build definition before the release of sbt 1.0.

@hawkw hawkw self-assigned this Aug 4, 2017
@hawkw
Copy link
Member Author

hawkw commented Aug 4, 2017

Note that the documentation does state that although using the Build trait for the build definition is deprecated,

you can still use project/*.scala file to organize your build and/or define ad-hoc plugins

So this won't require a complete restructuring of our build definition. We will just need to rewrite LinkerdBuild.scala as build.sbt.

@hawkw hawkw added this to the 1.2.0 milestone Aug 22, 2017
@hawkw
Copy link
Member Author

hawkw commented Aug 22, 2017

Since sbt 1.0.0 was released 12 days ago, I'd really like to get this done before we release Linkerd 1.2.0.

@hawkw hawkw removed this from the 1.2.0 milestone Aug 23, 2017
sgrankin added a commit to sgrankin/linkerd that referenced this issue Dec 4, 2017
As progress towards upgrading sbt (linkerd#1564).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant