-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1.1] Linkerd OOMs on too many [long] distinct names #1486
Comments
This is probably a duplicate of #1377 right? |
I cannot say for 100% but I have a feeling that this might be a different issue. I tried running the bash snippet from above modified in a way that it generates a lot of distinct names but all of them are short. I ran test up until I resolved >20k names and it didn't crash till then. So this might have something to do with long names... |
Given migration to Netty 4 this might not be an issue anymore, let me re-run the test with v1.1.1... |
Was able to reproduce the issue with 1.1.1, between 2000 and 2100 iterations. |
@ashald I know it's been a long time, but, do you remember what config you used for namerd or any other bits and pieces needed to reproduce this issue? I've tried to reproduce it with the latest linkerd 1.7.0 and I don't get the same behaviour as reported initially. My setup:
My results:
So, there's an increase in memory usage, but no OOM, so maybe something is missing from my setup. I've attached all files used to reproduce this. |
This test script makes requests to all distinct names, causing massive binding cache churn and a huge rate of allocations. It's not surprising that GC is not able to keep up with this rate of allocations. Linkerd is not intended to be able to deal with this type of traffic. I'm inclined to close this as won't fix unless there is a valid use case in here somewhere. |
Was chasing another issue in v1.1.0 but hit this with a next test-case:
Then just send requests with increasing length of the URI:
Eventually linkerd crashes with messages like this one:
The text was updated successfully, but these errors were encountered: