Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json parsing error stat for namerd #1393

Open
stevej opened this issue Jun 15, 2017 · 1 comment
Open

Add json parsing error stat for namerd #1393

stevej opened this issue Jun 15, 2017 · 1 comment

Comments

@stevej
Copy link

stevej commented Jun 15, 2017

When we fail to parse JSON from the k8s namer (or I suppose any namer, really), we should make sure to increment an error counter.

This would have made resolving #1361 a little easier.

(aside: this would be a good starter bug for one of our new peeps)

@adleong
Copy link
Member

adleong commented Jun 15, 2017

"fun" fact: for some reason there's no parsing error when we attempt to parse a string into an Int typed field, the object with the Int field is happily constructed. It's only much later when we attempt to use that field that a ClassCastException suddenly appears because (surprise!) it was a String all along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants