Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native packaging support #1084

Open
apakulov opened this issue Feb 17, 2017 · 4 comments
Open

Native packaging support #1084

apakulov opened this issue Feb 17, 2017 · 4 comments

Comments

@apakulov
Copy link
Contributor

Current build setup lacks an option to generate deb or rpm packages. It would be useful for docker integration too, instead of bundling binary into docker-image we can rely on apt-get to deliver it.

sbt-native-packager (https://www.scala-sbt.org/sbt-native-packager/introduction.html) seems like a nice fit for this.

I'd be happy to provide a PR if that is something you consider to future releases.

@adleong
Copy link
Member

adleong commented May 3, 2017

We'd definitely welcome a PR that adds this!

@apakulov
Copy link
Contributor Author

apakulov commented May 3, 2017

@adleong are you planning to maintain your own debian repo for linkerd project?

@adleong
Copy link
Member

adleong commented May 3, 2017

No, I don't think so.

@olix0r
Copy link
Member

olix0r commented May 3, 2017

We could potentially use packagecloud.io

Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
linkerd#1173)

This branch modifies the proxy's logic for opening a connection so
that when an attempted TLS handshake fails, the proxy will retry that
connection without TLS.

This is implemented by changing the `UpgradeToTls` case in the `Future`
implementation for `Connecting`, so that rather than simply wrapping
a poll to the TLS upgrade future with `try_ready!` (and thus failing
the future if the upgrade future fails), we reset the state of the
future to the `Plaintext` state and continue looping. The `tls_status`
field of the future is changed to `ReasonForNoTls::HandshakeFailed`,
and the `Plaintext` state is changed so that if its `tls_status` is
`HandshakeFailed`, it will no longer attempt to upgrade to TLS when the
plaintext connection is successfully established.

Closes linkerd#1084 

Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants