Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the linux file system information to reflect the same order #142

Merged
merged 2 commits into from
Sep 25, 2022

Conversation

n704
Copy link
Contributor

@n704 n704 commented Sep 23, 2022

Why

The order of directory in the Linux file system organization image and text under the image do not match. Along with that /root directory information is not provided.

As a new user tries to build mkdocs, they are getting an error. This will fix it.

Screen Shot 2022-09-23 at 4 24 30 PM

What is changing

  • By reordering the file system to match the order in the picture makes it more user readable. And /root is added.
  • mkdocs build command fails with the error message AttributeError: module 'jinja2' has no attribute 'contextfilter'. jinja2 added to requirement.txt and set to 3.0.3
  • Multiple "and" in the What are Linux operating systems section.

Changes

Screen Shot 2022-09-23 at 4 23 44 PM

…n the image.

* requirement.txt modified. added jinja2==3.0.3 to avoid error.
@sumeshpremraj
Copy link
Collaborator

sumeshpremraj commented Sep 24, 2022

@n704 why are you pinning to 3.0.3, looks like < 3.1.0 is enough https://twitter.com/readthedocs/status/1507388916013314048
Can you update the PR? Rest look good

@n704
Copy link
Contributor Author

n704 commented Sep 25, 2022

@sumeshpremraj I have updated the requirement.txt with jinja2<3.1.0

@sumeshpremraj
Copy link
Collaborator

Thanks @n704 for your contribution!

@sumeshpremraj sumeshpremraj merged commit 944e497 into linkedin:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants