Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightly CLI not working for pytorch lightning versions < 1.5 #912

Closed
IgorSusmelj opened this issue Aug 25, 2022 · 0 comments
Closed

Lightly CLI not working for pytorch lightning versions < 1.5 #912

IgorSusmelj opened this issue Aug 25, 2022 · 0 comments

Comments

@IgorSusmelj
Copy link
Contributor

IgorSusmelj commented Aug 25, 2022

As we learned from #905 (review) the earlier pytorch lightning versions (<1.5) are not compatible with the lightly cli for training SSL models.

Let's discuss here how we want to resolve that:

  • we can make an if/else statement to ensure compatibility with earlier versions. This is low effort but it's a short/mid-term solution. Newer changes of pytorch lightning might break again
  • we can drop the dependency of pytorch lightning altogether (it's only used in the cli). That would be medium effort.
  • we just leave it as it is knowing that older versions might not be fully compatible
@michal-lightly michal-lightly changed the title Lightly CLI not working for pytorch lightning versions < 1.4 Lightly CLI not working for pytorch lightning versions < 1.5 Aug 25, 2022
@guarin guarin closed this as completed Feb 7, 2023
@guarin guarin reopened this Feb 7, 2023
@guarin guarin closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants