Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some quickstarts still using a regular client instead of component client in integration tests #2028

Open
efgpinto opened this issue Feb 8, 2024 · 2 comments
Assignees
Labels
Documentation Improvements or additions to the documentation kalix-runtime Runtime and SDKs sub-team

Comments

@efgpinto
Copy link
Member

efgpinto commented Feb 8, 2024

Found at least 2 quickstarts that still use a regular WebClient in integration tests, inteads of the component client.
I think we should use the ComponentClient unless there is a specific reason to use a WebClient.

Samples in need of update, here and here.

@efgpinto efgpinto added enhancement New feature or request Documentation Improvements or additions to the documentation kalix-runtime Runtime and SDKs sub-team and removed enhancement New feature or request labels Feb 8, 2024
@aludwiko aludwiko self-assigned this Feb 15, 2024
@aludwiko
Copy link
Contributor

Actually, a lot of samples use WebClient in tests, and I have some second thoughts about changing this. For instance, it might be surprising to see the ComponentClient in tests for samples/quickstarts that don't use it in the implementation. Would require some additional cognitive load to understand what it is, search the docs, etc., and we aimed to make them simple to digest. WDYT @ennru ?

@ennru
Copy link
Member

ennru commented Feb 19, 2024

I agree, these introductory examples will be easier to consume with less Kalix specifics. So let's keep the Spring WebClient unless the code is in a more advanced Kalix context already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to the documentation kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

No branches or pull requests

3 participants