Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: consider not producing span for ignored events #2025

Open
efgpinto opened this issue Feb 8, 2024 · 0 comments
Open

Tracing: consider not producing span for ignored events #2025

efgpinto opened this issue Feb 8, 2024 · 0 comments
Labels
bug Something isnt working kalix-runtime Runtime and SDKs sub-team

Comments

@efgpinto
Copy link
Member

efgpinto commented Feb 8, 2024

When we have an Action subscribing to an ESE but which only handles 1 event and ignores the rest. The generated trace for an event that is ignored still includes a span for the Action. Additionally, the span is wrongly marked as belonging to the existing handler.

Example:

  • GetRandomPhotoActionAsync handles only UserAdded events so HandleAdd is the only declared handler there
  • however, when a UserNameChanged is produced, we get a span Action : GetRandomPhotoActionAsync HandleAddas shown below.
Screenshot 2024-02-08 at 16 31 32

Ideally, I think we should not produce a span for ignored events. But if we must, then would be better to have it named correctly.

@efgpinto efgpinto added bug Something isnt working kalix-runtime Runtime and SDKs sub-team labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isnt working kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

No branches or pull requests

1 participant