Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick right logging settings and docker compose when using mvn modules #2012

Open
efgpinto opened this issue Feb 6, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@efgpinto
Copy link
Member

efgpinto commented Feb 6, 2024

Currently, if you have a mvn project with modules, such as

project
\- module1 (with the normal structure of a kalix service)
\- pom.xml

Running mvn kalix:runAll on module1 works as expected. However, if running on the IDE, it will not pickup the correct logback-dev-mode.xml nor will it start the docker-compose.yml. To do it, the user will need to add this to the VM options in the IDE running config:
-Dlogging.config=module1/src/main/resources/logback-dev-mode.xml -Dkalix.dev-mode.docker-compose-file=module1/docker-compose.yml

I think we should be able to correctly pick up both the config and the docker-compose file by default.

@efgpinto efgpinto added the enhancement New feature or request label Feb 6, 2024
@octonato
Copy link
Member

octonato commented Feb 6, 2024

This will be tricky.

We can detect that we are running on dev-mode and look up files at the root of the project, but we assumed that the project root will always be the same as the process root.

When we run the main function, we can't know where is the process root and we can't know where is the main located. Is it under module1 or module2? Which directory should we append to src/main/resources?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants