default_poller_group vs distributed_poller_group

[haydenseitz]

The problem

There are multiple places in documentation and in the LibreNMS web UI that use default_poller_group with different meanings. One seems to be used as the default polling group that a new device is added to and the other seems to be the default polling group that a distributed poller will poll when there is no other setting.

References to default_poller_group used as group that new devices are added to:

• librenms/doc/Extensions/Auto-Discovery.md

  Line 204 in 07655c2

  Newly discovered devices will be added to the `default_poller_group`, this value defaults to 0 if unset.

• librenms/app/Console/Commands/DeviceAdd.php

  Line 52 in 07655c2

  return Config::get('default_poller_group');

• librenms/app/Actions/Device/ValidateDeviceAndCreate.php

  Line 189 in 07655c2

  $this->device->poller_group = $this->device->poller_group ?: Config::get('default_poller_group', 0);

References to default_poller_group used as default group for distributed pollers to poll:

• librenms/lang/en/settings.php

  Line 644 in 07655c2

  'default_poller_group' => [

• librenms/app/Http/Controllers/PollerController.php

  Line 40 in 07655c2

  'default_group_id' => Config::get('default_poller_group'),

References to distributed_poller_group used as default group for distributed pollers to poll:

• librenms/discovery.php

  Line 99 in 07655c2

  if (! empty(\LibreNMS\Config::get('distributed_poller_group'))) {

• librenms/LibreNMS/service.py

  Line 116 in 07655c2

  self.group = ServiceConfig.parse_group(

I have always used default_poller_group as the default group that new distributed pollers are assigned to, but comparing to the variable distributed_poller_group, it seems like this may not be the intended use.

Output of ./validate.php

923eb844770d:/opt/librenms$ ./validate.php 
===========================================
Component | Version
--------- | -------
LibreNMS  | 24.3.0 (2024-04-06T04:25:48-07:00)
DB Schema | 2024_02_07_151845_custom_map_additions (291)
PHP       | 8.2.17
Python    | 3.11.8
Database  | MariaDB 10.5.19-MariaDB-1:10.5.19+maria~ubu2004
RRDTool   | 1.8.0
SNMP      | 5.9.4
===========================================

[OK]    Installed from the official Docker image; no Composer required
[OK]    Database connection successful
[OK]    Database Schema is current
[OK]    SQL Server meets minimum requirements
[OK]    lower_case_table_names is enabled
[OK]    MySQL engine is optimal
[OK]    Database and column collations are correct
[OK]    Database schema correct
[OK]    MySQL and PHP time match
[OK]    Distributed Polling setting is enabled globally
[OK]    Connected to rrdcached
[OK]    Active pollers found
[OK]    Dispatcher Service is enabled
[OK]    Locks are functional
[OK]    No python wrapper pollers found
[OK]    Redis is functional
[WARN]  IPv6 is disabled on your server, you will not be able to add IPv6 devices.
[OK]    rrdtool version ok
[OK]    Connected to rrdcached
[WARN]  Updates are managed through the official Docker image

What was the last working version of LibreNMS?

No response

Anything in the logs that might be useful for us?

No response

[murrant]

default_poller_group is for adding devices.
distributed_poller_group is usually set in local config.php files (not globally) The webui setting is preferred, which can set per-poller groups from the global context. It might be good if this configuration is moved out of the database and into the global config (it would still use per-node config)

In summary, I think the middle two are wrong. default_poller_group is for adding devices.

Any PRs to make things better are welcomed.