Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift count >= width of type #45

Closed
xantares opened this issue Mar 14, 2014 · 1 comment
Closed

shift count >= width of type #45

xantares opened this issue Mar 14, 2014 · 1 comment

Comments

@xantares
Copy link
Contributor

liblogicalaccess/plugins/pluginsreaderproviders/rwk400/commands/desfirerwk400commands.cpp:189:10: warning: shift count >= width of type [-Wshift-count-overflow]
tmp <<= 8;

will it be zeroed !?

@Maxhy
Copy link
Member

Maxhy commented Mar 17, 2014

Yes inded...
This reader was implemented but never fully tested by the person who did it. The reader itself became deprecated (replaced by HID iClass SE models) and I believe nobody will develop on it anymore.
I created a new repository https://github.com/islog/liblogicalaccess-oldy to keep unmaintained readers and cards plugins source code online, where I moved the rwk400 reader.

@Maxhy Maxhy closed this as completed Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants