Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_clone_into no longer exists #402

Closed
mduggan opened this issue Aug 13, 2014 · 3 comments
Closed

git_clone_into no longer exists #402

mduggan opened this issue Aug 13, 2014 · 3 comments

Comments

@mduggan
Copy link
Contributor

mduggan commented Aug 13, 2014

Trying to use pygit2 against the current head libgit2 fails because git_clone_into has been removed from the public API.

I'd submit a pull request, but I'm not sure what the correct "fix" is. Is it just to completely remove the clone_into function and corresponding definition in decl.h?

@carlosmn
Copy link
Member

pygit2 works against the released versions of libgit2. There is no
branch which tracks the next release, so there's nowhere to put such a
fix. Not that there can't be, but such a branch would be out of date
very quickly and there's not really the manpower in this project to keep
such a branch.

As for the fix itself, the functionality that git_clone_into provided
has been moved into the repository and remote factory callbacks in the
git_clone options.

@mduggan
Copy link
Contributor Author

mduggan commented Aug 14, 2014

No problem, it doesn't really bother me, just thought I'd report. I was debugging issue #403 and thought it might be better to update to the latest libgit2 first, but apparently not :)

@carlosmn
Copy link
Member

libgit2 v0.22 has been released, and we now support this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants