-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSO doesn’t nor enables users to set storage size #153
Labels
Comments
https://github.com/ThaUnknown/jassub/blob/main/src/jassub.js#L286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ASS rendering depends on the original video’s storage resolution.
Even if we can somehow obtain the video resolution of the current associated video stream, this may not be correct if there are multiple resolutions available to choose from or resolution is dynamically adjusted for bandwidth. Thus JSO should at least (also?) provide a means for users of the regular JS interface to manually set storage size from e.g. some out-of-band metadata.
Currently all subtitles (without
LayoutRes{X,Y}
) for which libass’ fallback guess is wrong and use affected features thus render incorrectly.The text was updated successfully, but these errors were encountered: