Better support for secondary stick in DirectInput driver #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b3b3a0
to
709051d
Compare
SiegeLord
reviewed
Feb 11, 2024
| // ...it may be that using `Z` really is common for some input devices. | ||
| // | ||
| // Solution came from https://www.gamedev.net/forums/topic/613913-directinput-identifying-second-thumbstick/ | ||
| if (j) |
There was a problem hiding this comment.
Now that we have a backwards compatibility mechanism, we can merge a version of this. Could you add check like this https://github.com/liballeg/allegro5/blob/8575e373ab79c7bc25f8425990fc6780e75e69c8/src/macosx/hidjoy.m#L192C4-L192C76 here, so this behavior can be configured?
Also, could j be called something more informative, like... offset_override maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced here: #1462 (comment)
This patch fixes detection of the secondary thumbstick. I tested on two devices: a PS4 Dualshock, and a Stadia controller.
The code assumed that Rx, Ry, Rz will always be what maps to the secondary stick. However, that apparently was too hard for controller manufacturers to do. For example, my above mentioned controllers use Z and Rz for the second stick. Short of including a database of controller mappings, this patch introduces a heuristic to guess how to map to a secondary stick.
The idea for the solution came from https://www.gamedev.net/forums/topic/613913-directinput-identifying-second-thumbstick/