Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can drop display:none #95

Closed
AlexHaaniWink opened this issue Nov 24, 2015 · 3 comments
Closed

Can drop display:none #95

AlexHaaniWink opened this issue Nov 24, 2015 · 3 comments
Labels

Comments

@AlexHaaniWink
Copy link

We're combining this with http:https://isotope.metafizzy.co/ . Though that probably does not specifically matter.
In some situations, for some elements a set 'display: none' is dropped. Strangely not for all hidden elements.

I haven't gone through all the code so I don't see why it would sometimes not drop display:none.
But https://github.com/liabru/jquery-match-height/blob/master/jquery.matchHeight.js#L253 does not seem handy. I think it would be better if on line 235 you store the original display value in a variable and apply that on line 253 again.

@liabru
Copy link
Owner

liabru commented Nov 24, 2015

Is display: none set on the style attribute rather than via CSS (or set via JS)?
Looks like that would indeed fail, as it currently will revert to what has been set via CSS.
I'll look into getting this fixed.

@AlexHaaniWink
Copy link
Author

It is set via the style attribute yes. Isotope uses that to filter out elements.

@liabru liabru added the bug label Dec 5, 2015
@liabru liabru closed this as completed in 878ff96 Dec 26, 2015
@liabru
Copy link
Owner

liabru commented Dec 26, 2015

Thanks, should be resolved in the latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants