Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the height of hidden element #12

Closed
pinin opened this issue Jun 27, 2014 · 6 comments
Closed

Adjust the height of hidden element #12

pinin opened this issue Jun 27, 2014 · 6 comments

Comments

@pinin
Copy link

pinin commented Jun 27, 2014

Thank you for this great plugin. Should I question whether it is possible to set the same height for hidden elements. specifically for bootstrap tabs.
Thanks

@liabru
Copy link
Owner

liabru commented Jun 27, 2014

The plugin doesn't currently handle this case, you must apply matchHeight while the content is visible.

See issue 1.

Though, this is on my list of edge cases to fix. Hopefully I'll have a solution for this implemented soon.

@liabru liabru closed this as completed in 9a8944b Jul 3, 2014
@liabru
Copy link
Owner

liabru commented Jul 3, 2014

I've just pushed a change that now automatically handles hidden elements like those in tabs.
I tested it working with Bootstrap tabs.

If you're still having this issue, would you mind giving the latest master version a try?

@pinin
Copy link
Author

pinin commented Jul 3, 2014

OK, I'm sorry I was out. Thank you, I'll test. Plugin is great.
Thanks

@pinin
Copy link
Author

pinin commented Jul 3, 2014

probably do not know how to use.
This example does not work me

$('.tab-content').each(function () {
$(this).children('.tab-pane').matchHeight();
});

@liabru
Copy link
Owner

liabru commented Jul 3, 2014

Try this

$('.tab-content .tab-pane').matchHeight(false);

You need to pass false to disable the default row detection (since you only have one item per row), also make sure you select all .tab-pane in a single selection rather than separate.

See this jsfiddle

@pinin
Copy link
Author

pinin commented Jul 3, 2014

Yessss :) OK super thans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants