From 445799d32e72c0946e7694d81218285be3a818ec Mon Sep 17 00:00:00 2001 From: liabru Date: Fri, 25 Dec 2015 14:36:23 +0000 Subject: [PATCH] added test for remove --- test/page/test.html | 25 +++++++++++++++++++++---- test/specs/matchHeight.spec.js | 24 ++++++++++++++++++++++-- 2 files changed, 43 insertions(+), 6 deletions(-) diff --git a/test/page/test.html b/test/page/test.html index 29c936d..4c66cb6 100644 --- a/test/page/test.html +++ b/test/page/test.html @@ -397,20 +397,37 @@

min-height

-

min-height

+

inline style

Phasellus ut nibh fermentum, vulputate urna vel, semper diam.

Aenean semper felis ipsum, vulputate consequat dui elementum vel.

-

min-height

+

inline style

Phasellus ut nibh fermentum, vulputate urna vel, semper diam. Nunc sollicitudin felis ut pellentesque fermentum. In erat mi, pulvinar sit amet tincidunt vitae, gravida id felis. Phasellus hendrerit erat sed porta imperdiet. Vivamus viverra ipsum tortor, et congue mauris porttitor ut.

-

min-height

+

inline style

Aenean semper felis ipsum, vulputate consequat dui elementum vel. Nullam odio eros, sagittis vitae lectus id, pretium viverra lectus. Etiam auctor dolor non dui ultricies pulvinar.

-

min-height

+

inline style

+

Aenean semper.

+
+
+ +
+
+

removed

+

Phasellus ut nibh fermentum, vulputate urna vel, semper diam.

+

Aenean semper felis ipsum, vulputate consequat dui elementum vel.

+
+
+

Phasellus ut nibh fermentum, vulputate urna vel, semper diam. Nunc sollicitudin felis ut pellentesque fermentum. In erat mi, pulvinar sit amet tincidunt vitae, gravida id felis. Phasellus hendrerit erat sed porta imperdiet. Vivamus viverra ipsum tortor, et congue mauris porttitor ut.

+
+
+

Aenean semper felis ipsum, vulputate consequat dui elementum vel. Nullam odio eros, sagittis vitae lectus id, pretium viverra lectus. Etiam auctor dolor non dui ultricies pulvinar.

+
+

Aenean semper.

diff --git a/test/specs/matchHeight.spec.js b/test/specs/matchHeight.spec.js index 0d0e4cb..627b3ff 100644 --- a/test/specs/matchHeight.spec.js +++ b/test/specs/matchHeight.spec.js @@ -107,7 +107,7 @@ describe('matchHeight', function() { expect(1.0001).not.toBeWithinTolerance(0); $('.simple-items, .image-items, .nested-items-parent, .nested-items,' + - '.fixed-items, .inline-block-items, .inline-flex-items, .items-with-float, .inline-style-items') + '.fixed-items, .inline-block-items, .inline-flex-items, .items-with-float, .inline-style-items, .remove-items') .each(function() { var $items = $(this).children('.item'), rows = $.fn.matchHeight._rows($items); @@ -148,7 +148,7 @@ describe('matchHeight', function() { $.fn.matchHeight._update(); $('.simple-items, .image-items,' + - '.fixed-items, .inline-block-items, .inline-flex-items, .items-with-float, .inline-style-items') + '.fixed-items, .inline-block-items, .inline-flex-items, .items-with-float, .inline-style-items, .remove-items') .each(function() { var $items = $(this).children('.item'), targetHeight = $items.first().outerHeight(), @@ -407,6 +407,26 @@ describe('matchHeight', function() { done(); }); + + it('can be removed', function(done) { + var matchHeight = $.fn.matchHeight, + $item = $('.remove-items').find('.item-0'), + isInAnyGroup = false; + + $item.matchHeight({ remove: true }); + expect($item[0].style.height).toBeFalsy(); + + for (var i = 0; i < matchHeight._groups.length; i += 1) { + var group = matchHeight._groups[i]; + if ($.inArray($item[0], group.elements) !== -1) { + isInAnyGroup = true; + break; + } + } + + expect(isInAnyGroup).toBeFalsy(); + done(); + }); });