-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Eccentricity #117
Comments
Yes I think that's definitely a good idea. I thought this was well made but its not at all. As you say: when using a Here is a proposed implementation:
This way we inforce shape-specific detection blocks to be truly shape-specific :). What do you think? |
Perfect, yes that's exactly how I have implemented it so far! I will clean it up and pull request soon. |
That's awesome, thanks! 🙏🏼 |
What do you think about using eccentricity as opposed to minor length as a threshold in detection blocks?
I feel that then to rule out small stars one can use min_area, and using eccentricity rather than minor_length would then be a pure parameter to control the allowed ellipticity of stars. Using minor length seems to try to do both at the same time, and sometimes i then find it difficult to constrain the parameters correctly to only detect the stars i want. What do you think?
I will include it in the branch i'm building, if you like the idea!
The text was updated successfully, but these errors were encountered: