Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't do a tqdm when generating just one item #723

Closed
leondz opened this issue Jun 5, 2024 · 3 comments
Closed

don't do a tqdm when generating just one item #723

leondz opened this issue Jun 5, 2024 · 3 comments
Labels
cli Command-line interface functions generators Interfaces with LLMs

Comments

@leondz
Copy link
Owner

leondz commented Jun 5, 2024

also visible in atkgen
@leondz leondz added generators Interfaces with LLMs cli Command-line interface functions labels Jun 5, 2024
@leondz
Copy link
Owner Author

leondz commented Jul 5, 2024

triggered when model doesn't support parallel, and generations = 1.

@leondz
Copy link
Owner Author

leondz commented Jul 5, 2024 •
edited
Loading

expecting:

  • generations 1 - no generations progress bar ❌
  • model supports multiple generations in one call - no generations progress bar ❌
  • generations >1, no support for multiple generations - progress bar ✅

test cases:

  • -g 1, supports_multiple_generations == True: ❌
  • -g 5, supports_multiple_generations == True: ❌
  • -g 1, supports_multiple_generations == False: ❌
  • -g 5, supports_multiple_generations == False: ✅

@leondz
Copy link
Owner Author

leondz commented Jul 5, 2024

resolved in 44102d6

@leondz leondz closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Command-line interface functions generators Interfaces with LLMs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leondz