Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: golf some term/rw proofs using linear_combination #19353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrmacbeth
Copy link
Member


Open in Gitpod

Copy link

PR summary b689439638

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@hrmacbeth
Copy link
Member Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit b689439.
There were no significant changes against commit 06553ac.

Copy link

File Instructions %
build -6.574⬝10⁹ (+0.00%)
Mathlib.NumberTheory.Zsqrtd.Basic -1.333⬝10⁹ (-1.64%)
Mathlib.Analysis.Convex.Slope -5.489⬝10⁹ (-5.90%)

@hrmacbeth hrmacbeth added the WIP Work in progress label Nov 22, 2024
@grunweg
Copy link
Collaborator

grunweg commented Nov 22, 2024

I won't approve this yet, as it's still labelled WIP - but from a cursory look, these golfs look great!

@grunweg grunweg self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants