-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Algebra/Bilinear): generalize to non-commutative base rings #19232
Open
eric-wieser
wants to merge
6
commits into
master
Choose a base branch
from
eric-wieser/rework-Algebra.Bilinear
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+142
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 06fbed383eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
eric-wieser
force-pushed
the
eric-wieser/rework-Algebra.Bilinear
branch
from
November 18, 2024 23:27
9a7fa7e
to
d4e68cf
Compare
!bench |
Here are the benchmark results for commit 06fbed3. Benchmark Metric Change
===========================================================
- ~Mathlib.RingTheory.PiTensorProduct instructions 13.9% |
2 files, Instructions -2.0⬝10⁹
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unnecessary
IsScalarTower R A A
andSMulCommClass R A A
arguments fromLinearMap.mulLeft
andLinearMap.mulRight
, respectively.As described in the new docstring, this allows respective specializations to
R := Aᵐᵒᵖ
andR := A
.Unfortunately all of the lemmas have to be reordered to take advantage of these relaxed assumptions.
In the chaos, a few lemmas also became generalized to non-unital rings.
There is some overlap here with
DistribMulAction.toLinearMap
, but that doesn't work in the case of non-unital rings.