Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SetTheory/Ordinal/Exponential): redefine ordinal exponential without bsup #19145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Nov 17, 2024

Ordinal.bsup is planned to be deprecated.


Open in Gitpod

@vihdzp vihdzp added the t-set-theory Set theory label Nov 17, 2024
Copy link

github-actions bot commented Nov 17, 2024

PR summary 4bf4d33a20

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ opow
+ zero_opow_le
- opow_def
- pow
- zero_opow'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
5095 -1 porting notes

Current commit 4bf4d33a20
Reference commit e3327a6356

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@Command-Master Command-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Perhaps keep opow_def, but using the new definition?

@vihdzp
Copy link
Collaborator Author

vihdzp commented Nov 18, 2024

The theorems in lines 42-60 completely characterize the ordinal exponential. The definition (particularly written as it is with 1 - a) should remain a private implementation detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-set-theory Set theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants