Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Geometry/Manifold): manifolds are locally path-connected #17142

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

peabrainiac
Copy link
Collaborator

@peabrainiac peabrainiac commented Sep 25, 2024

Shows that spaces modelled on locally path-connected spaces are themselves locally path-connected, and that the common model spaces EuclideanHalfSpace n and EuclideanQuadrant n are locally path-connected.


Open in Gitpod

peabrainiac and others added 8 commits September 20, 2024 16:47
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@peabrainiac peabrainiac added t-differential-geometry Manifolds etc t-topology Topological spaces, uniform spaces, metric spaces, filters labels Sep 25, 2024
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

PR summary f3395b776c

Import changes exceeding 2%

% File
+64.56% Mathlib.Geometry.Manifold.ChartedSpace

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Geometry.Manifold.ChartedSpace 711 1170 +459 (+64.56%)
Mathlib.Analysis.Complex.UpperHalfPlane.Topology 1723 1646 -77 (-4.47%)
Import changes for all files
Files Import difference
Mathlib.Analysis.Complex.UpperHalfPlane.Topology -77
Mathlib.Analysis.Complex.UpperHalfPlane.FunctionsBoundedAtInfty -72
Mathlib.NumberTheory.ModularForms.EisensteinSeries.UniformConvergence Mathlib.NumberTheory.ModularForms.EisensteinSeries.IsBoundedAtImInfty -59
Mathlib.Geometry.Manifold.Sheaf.Basic 443
Mathlib.Geometry.Manifold.LocalInvariantProperties Mathlib.Geometry.Manifold.ChartedSpace 459

Declarations diff

+ ChartedSpace.locPathConnectedSpace
+ Convex.locPathConnectedSpace
+ EuclideanHalfSpace.convex
+ EuclideanHalfSpace.pathConnectedSpace
+ EuclideanQuadrant.convex
+ EuclideanQuadrant.pathConnectedSpace
+ instance (priority := 100) LocallyConvexSpace.toLocPathConnectedSpace [Module ℝ E]
+ instance : LocPathConnectedSpace (EuclideanQuadrant n)
+ instance [NeZero n] : LocPathConnectedSpace (EuclideanHalfSpace n)
+ pathComponentIn_mem_nhds
- instance (priority := 100) LocallyConvexSpace.toLocallyConnectedSpace [Module ℝ E]
- instance (priority := 100) NormedSpace.instLocPathConnectedSpace : LocPathConnectedSpace E

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Sep 25, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 18, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 19, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 20, 2024
@peabrainiac
Copy link
Collaborator Author

peabrainiac commented Nov 20, 2024

This should now be up-to-date and free of merge conflicts. There is one thing still left to decide though: should the two instances LocallyConvexSpace.toLocallyConnectedSpace and NormedSpace.instLocPathConnectedSpace that are made redundant by this PR be removed? I assume for LocallyConvexSpace.toLocallyConnectedSpace the answer is yes, since any file that imports it will also have access to instLocallyConnectedSpace (which I realise now should probably be namespaced) and LocallyConvexSpace.toLocPathConnectedSpace from this PR. NormedSpace.instLocPathConnectedSpace is only made redundant by NormedSpace.toLocallyConvexSpace though, which is a bit further up in the import graph; removing it might thus require adding more imports to a few files. I will try to push commits removing those two instances in a moment, and would appreciate feedback on whether those commits should be kept or undone.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 20, 2024
@peabrainiac
Copy link
Collaborator Author

Looks like there were actually no further import changes necessary - at least locally, mathlib still built just fine after removing both instances. I'm guessing local path-connectedness of normed spaces wasn't used much yet.

@peabrainiac
Copy link
Collaborator Author

I think I was wrong about Mathlib.Analysis.Convex.Normed not importing Mathlib.Analysis.LocallyConvex.WithSeminorms - I don't know how to check transitive imports like that, and just looked through the direct imports without seeing any connection. Either way though, I think this PR should now be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-differential-geometry Manifolds etc t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants