-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Geometry/Manifold): manifolds are locally path-connected #17142
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR summary f3395b776cImport changes exceeding 2%
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Geometry.Manifold.ChartedSpace | 711 | 1170 | +459 (+64.56%) |
Mathlib.Analysis.Complex.UpperHalfPlane.Topology | 1723 | 1646 | -77 (-4.47%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.Analysis.Complex.UpperHalfPlane.Topology |
-77 |
Mathlib.Analysis.Complex.UpperHalfPlane.FunctionsBoundedAtInfty |
-72 |
Mathlib.NumberTheory.ModularForms.EisensteinSeries.UniformConvergence Mathlib.NumberTheory.ModularForms.EisensteinSeries.IsBoundedAtImInfty |
-59 |
Mathlib.Geometry.Manifold.Sheaf.Basic |
443 |
Mathlib.Geometry.Manifold.LocalInvariantProperties Mathlib.Geometry.Manifold.ChartedSpace |
459 |
Declarations diff
+ ChartedSpace.locPathConnectedSpace
+ Convex.locPathConnectedSpace
+ EuclideanHalfSpace.convex
+ EuclideanHalfSpace.pathConnectedSpace
+ EuclideanQuadrant.convex
+ EuclideanQuadrant.pathConnectedSpace
+ instance (priority := 100) LocallyConvexSpace.toLocPathConnectedSpace [Module ℝ E]
+ instance : LocPathConnectedSpace (EuclideanQuadrant n)
+ instance [NeZero n] : LocPathConnectedSpace (EuclideanHalfSpace n)
+ pathComponentIn_mem_nhds
- instance (priority := 100) LocallyConvexSpace.toLocallyConnectedSpace [Module ℝ E]
- instance (priority := 100) NormedSpace.instLocPathConnectedSpace : LocPathConnectedSpace E
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This should now be up-to-date and free of merge conflicts. There is one thing still left to decide though: should the two instances LocallyConvexSpace.toLocallyConnectedSpace and NormedSpace.instLocPathConnectedSpace that are made redundant by this PR be removed? I assume for |
Looks like there were actually no further import changes necessary - at least locally, mathlib still built just fine after removing both instances. I'm guessing local path-connectedness of normed spaces wasn't used much yet. |
I think I was wrong about |
Shows that spaces modelled on locally path-connected spaces are themselves locally path-connected, and that the common model spaces
EuclideanHalfSpace n
andEuclideanQuadrant n
are locally path-connected.pathComponentIn
#16983