Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SetTheory/Ordinal/CantorNormalForm): CNF.exponents and CNF.coeffs #15915

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Aug 17, 2024

We rewrite theorems about the Cantor Normal Form in terms of their lists of exponents and coefficients, instead of awkwardly talking about their first and second entries.

We also put all theorems about the CNF in its own namespace. This keeps us from cluttering the Ordinal namespace, and it also avoids having to prefix everything by CNF_ constantly.


Open in Gitpod

@vihdzp vihdzp added the t-logic Logic (model theory, etc) label Aug 17, 2024
Copy link

github-actions bot commented Aug 17, 2024

PR summary bfe82bc7c1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coeffs
+ coeffs_zero
+ exponents
+ exponents_sorted
+ exponents_zero
+ foldr
+ le_log_of_mem_exponents
+ lt_of_mem_coeffs
+ mem_coeffs_iff
+ mem_coeffs_of_mem
+ mem_exponents_iff
+ mem_exponents_of_mem
+ ne_zero
+ of_le_one
+ of_lt
+ one
+ pos_of_mem_coeffs
+ zero_left
+ zero_right
- one_CNF

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Aug 28, 2024

I renamed CNF.coefficients to CNF.coeffs for parity with Polynomial.coeffs.

@vihdzp vihdzp changed the title chore(SetTheory/Ordinal/CantorNormalForm): CNF.exponents and CNF.coefficients chore(SetTheory/Ordinal/CantorNormalForm): CNF.exponents and CNF.coeffs Aug 28, 2024
@vihdzp vihdzp requested a review from b-mehta September 17, 2024 06:31
@digama0
Copy link
Member

digama0 commented Sep 21, 2024

I don't like that this is mixing new theory and unrelated proof cleanup. Please do these things separately.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Sep 21, 2024

Yeah, looking back at my code cleanup I'm not sure I agree with everything I did. I'll put that in a separate PR and clean up this one afterwards.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Sep 21, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 11, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 31, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@github-actions github-actions bot added the t-set-theory Set theory label Oct 31, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 31, 2024
@vihdzp
Copy link
Collaborator Author

vihdzp commented Oct 31, 2024

PR should be ready for review now! Most of the diff is just due to the deprecations, and all the changes here should hopefully be non-controversial.

@YaelDillies
Copy link
Collaborator

You have two paragraphs in your PR description. Can you make each paragraph its own PR?

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes t-logic Logic (model theory, etc) t-set-theory Set theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants