-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(SetTheory/Ordinal/CantorNormalForm): CNF.exponents
and CNF.coeffs
#15915
base: master
Are you sure you want to change the base?
Conversation
PR summary bfe82bc7c1Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
I renamed |
CNF.exponents
and CNF.coefficients
CNF.exponents
and CNF.coeffs
I don't like that this is mixing new theory and unrelated proof cleanup. Please do these things separately. |
Yeah, looking back at my code cleanup I'm not sure I agree with everything I did. I'll put that in a separate PR and clean up this one afterwards. |
Co-authored-by: YnirPaz <[email protected]>
Co-authored-by: YnirPaz <[email protected]>
Co-authored-by: YnirPaz <[email protected]>
Co-authored-by: YnirPaz <[email protected]>
Co-authored-by: YnirPaz <[email protected]>
This PR/issue depends on: |
PR should be ready for review now! Most of the diff is just due to the deprecations, and all the changes here should hopefully be non-controversial. |
You have two paragraphs in your PR description. Can you make each paragraph its own PR? |
We rewrite theorems about the Cantor Normal Form in terms of their lists of exponents and coefficients, instead of awkwardly talking about their first and second entries.
We also put all theorems about the CNF in its own namespace. This keeps us from cluttering the
Ordinal
namespace, and it also avoids having to prefix everything byCNF_
constantly.