Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RingTheory/MvPolynomial/Ideal): introduce new lemmas about MvPolynomial Ideals #15809

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

archiebrowne
Copy link
Collaborator

Four new lemmas about MvPolynomialIdeals sub_span_span_sub, span_eq_iff_basis_sub, mem_basis_mem_span, mem_span_exists_dvd_mem_basis.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Aug 14, 2024
Copy link

github-actions bot commented Aug 14, 2024

PR summary ab19632c08

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mem_basis_mem_span
+ mem_span_exists_dvd_mem_basis
+ span_eq_iff_basis_sub
+ sub_span_span_sub

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@grunweg grunweg added the t-algebra Algebra (groups, rings, fields, etc) label Aug 15, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic comments, but no other objections from me.

Mathlib/RingTheory/MvPolynomial/Ideal.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Ideal.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/MvPolynomial/Ideal.lean Outdated Show resolved Hide resolved
archiebrowne and others added 3 commits September 11, 2024 14:51
remove .coe notation

Co-authored-by: Ruben Van de Velde <[email protected]>
fix indentation

Co-authored-by: Ruben Van de Velde <[email protected]>
fix proof indentation
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mem_basis_mem_span seems essentially the same as Ideal.subset_span, and also the first two lemmas are essentially already in the library.

What about removing them and just keep the last one?


variable [Nontrivial R]

/-- If a monomial `m` is contained in the span of a basis of monomials, there must be an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/-- If a monomial `m` is contained in the span of a basis of monomials, there must be an
/-- If a monomial `m` is contained in the span of a set of monomials, there must be an

@riccardobrasca riccardobrasca added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 24, 2024
@riccardobrasca
Copy link
Member

@archiebrowne are you still interested in working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants