-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RingTheory/MvPolynomial/Ideal): introduce new lemmas about MvPolynomial Ideals #15809
base: master
Are you sure you want to change the base?
Conversation
PR summary ab19632c08Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stylistic comments, but no other objections from me.
remove .coe notation Co-authored-by: Ruben Van de Velde <[email protected]>
fix indentation Co-authored-by: Ruben Van de Velde <[email protected]>
fix proof indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mem_basis_mem_span
seems essentially the same as Ideal.subset_span, and also the first two lemmas are essentially already in the library.
What about removing them and just keep the last one?
|
||
variable [Nontrivial R] | ||
|
||
/-- If a monomial `m` is contained in the span of a basis of monomials, there must be an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/-- If a monomial `m` is contained in the span of a basis of monomials, there must be an | |
/-- If a monomial `m` is contained in the span of a set of monomials, there must be an |
@archiebrowne are you still interested in working on this PR? |
Four new lemmas about MvPolynomialIdeals
sub_span_span_sub
,span_eq_iff_basis_sub
,mem_basis_mem_span
,mem_span_exists_dvd_mem_basis
.