Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update youtube-rotator extension #128

Open
robinfriedli opened this issue May 28, 2024 · 1 comment
Open

Update youtube-rotator extension #128

robinfriedli opened this issue May 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@robinfriedli
Copy link
Contributor

YoutubeIpRotatorSetup#forSource should be updated to replace the deprecated source manager. It would probably make more sense to move the extension to the youtube-source repo

@devoxin
Copy link
Member

devoxin commented May 28, 2024

There's an alternative method for using the rotator listed in the README of the youtube-source repo negating the need for a custom forSource method. Ideally, we would refactor it to work with any other source managers (provided the source supports IPv6) (edit: I believe IPv4 rotation is supported with the rotator so this is a non-issue), so I think for the time being it makes sense to keep it within lavaplayer until there's been further deliberation as to how we should approach IP rotation in general. Could be that the other sources take after YouTube and start cracking down on bots (i.e. Soundcloud) necessitating a general purpose rotator.

@topi314 topi314 added the enhancement New feature or request label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants