Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugins] Parse maven-metadata.xml when downloading #1049

Open
2 tasks done
topi314 opened this issue May 28, 2024 · 0 comments
Open
2 tasks done

[Plugins] Parse maven-metadata.xml when downloading #1049

topi314 opened this issue May 28, 2024 · 0 comments

Comments

@topi314
Copy link
Member

topi314 commented May 28, 2024

Change request

Right now Lavalink expects the maven artifacts to have the exact name as the artifact id.
But this isn't always the case, as an example when publishing a -SNAPSHOT release maven replaces SNAPSHOT with the current date. This then causes Lavalink to not being able to download the plugin anymore.

The solution is to instead read in the maven-metadata.xml which then points to the correct artifact for a certain plugin. What this also means is that you need a propper maven repository with a maven-metadata.xml to host Lavalink plugins, which was previously not needed.

Ideally we would implement this as an addition to the current way of doing it, which would allow us to not have to do this anymore.

Relevance

yes

Could this be a plugin instead?

no

Checklist

  • I have checked for duplicate issues
  • I have checked for existing plugins
@topi314 topi314 self-assigned this May 28, 2024
@topi314 topi314 removed their assignment Jun 21, 2024
@topi314 topi314 changed the title Parse maven-metadata.xml when downloading plugins [Plugins] Parse maven-metadata.xml when downloading Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant