Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Engine switch from arbitrary code exec to outputting XPath, type of action and other arguments #352

Closed
dhuynh95 opened this issue Jun 14, 2024 · 0 comments
Assignees
Labels
core core La Vague code HighPrio new feature new feature Security

Comments

@dhuynh95
Copy link
Collaborator

The NavigationEngine currently does arbitrary code execution, which is a bad practice and is no longer needed (we did it at the beginning because we wanted to provide the ability to invoke tools if needed, but things are well separated now in the PythonEngine who is specialized in calling tools).

We therefore should revamp the current Navigation Engine to output things like:

[
    {"Action": "Click",
     "XPath": "..."
     },
]

Then we provide specific code for each different driver, Selenium, Playwright or Chrome Extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core core La Vague code HighPrio new feature new feature Security
Projects
Status: Done
Development

No branches or pull requests

4 participants