PDF Viewer: Fix pdf text blurry #6843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok good, let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewer
full-screen, embedded
Issue
Text in rendered pdf pages are not clear.
This issue is related to the discussion on discord.
Reason & analysis
This is caused because of setting canvas height & weight to 100% (i.e adopt to the parent dimensions) causing it to wrongly scale.
Solution
Setting dimensions to 100% is required so that the page does not flicker on re-rendering (happens on zoom/resize etc).
So we only now set them when we are re-rendering and not beforehand.