Mobile: Migrate Dropdown, ScreenHeader to TypeScript #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-205
to
-212
| log_press() { | ||
| NavService.go('Log'); | ||
| } | ||
|
|
||
| status_press() { | ||
| NavService.go('Status'); | ||
| } |
There was a problem hiding this comment.
These methods were unused (I did a search in all files in the app-mobile/ directory).
Comment on lines
-558
to
+626
| {renderUndoButton(this.styles())} | ||
| {renderRedoButton(this.styles())} | ||
| {renderUndoButton()} | ||
| {renderRedoButton()} |
There was a problem hiding this comment.
renderUndoButton and renderRedoButton didn't/don't take any arguments.
laurent22
reviewed
Aug 19, 2022
|
Looks good now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Testing plan