-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: resolve #3695: Show notebook and note title in the title bar #4390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. There are a few issues which I've described in the comments below. Also please add unit tests for that new code.
@asrient, are you still interested in completing this pull request? |
Yes. I will complete asap. |
It's good now, but you've somehow bypassed the linter on the last commit so CI is failing. |
All good now, many thanks for the pull request @asrient! |
…itle bar (#4390)" This reverts commit c79c9c4. Reason: Still need to discuss how it should be implemented. Ref: https://discourse.joplinapp.org/t/testing-v1-8-2-title-bar-path-format-minor/16937/10
Unfortunately I had to revert this change as I realise we didn't discuss much what is the exact reason for this change, and how it should be implemented. Once it's clarified we can see about adding it back. Ref: https://discourse.joplinapp.org/t/testing-v1-8-2-title-bar-path-format-minor/16937/10 Revert commit: a0ead2c |
Hello. |
Naming the notebook somehow in the window title is a critical usability feature to enable a user to have separate "Work" and "Personal" databases, in combination with the "--profile" command line switch. |
Titlebar of the desktop electron app now shows the name of notebook and note title you are currently viewing.
The title convention used is: Note (Notebook) - Joplin