Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop,Mobile: Update Mermaid to v10.9.1 #10475

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented May 25, 2024

Summary

This pull request upgrades mermaid.js to version 10.9.1 from 10.6.1. See the mermaid releases page for a list of changes.

Testing plan

  1. Create a new note with the following content:
    ```mermaid
    graph LR
        A[$$n$$]
        B["$$n \over 2$$"]
        C["$$\frac{n}{2}$$"]
        A--"$$\mathcal{O}(1)$$"-->B
        A--"$$\mathcal{O}(1)$$"-->C
    ```
    
  2. Verify that the flowchart renders (and that the math also renders):
    screenshot: Flowchart with math
  3. Desktop only:
    1. Download a copy of the diagram using the download button and attach it to the note.
    2. Switch to the rich text editor.
    3. Verify that the original diagram and the attached SVG export render.

This has been tested successfully on Ubuntu 24.04 (desktop) and on an Android 12 emulator (mobile).

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop, Mobile: Update Mermaid to v10.9.1 Desktop,Mobile: Update Mermaid to v10.9.1 May 25, 2024
@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented May 25, 2024

Temporarily converting to a draft — there's an issue with math typesetting in diagrams caused by a use of white-space: pre in Joplin. Edit: The sequence diagram example was rendering incorrectly (some text missing). This has been fixed.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as draft May 25, 2024 06:03
@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review May 25, 2024 06:11
@personalizedrefrigerator personalizedrefrigerator added the renderer About the note renderer label May 25, 2024
@laurent22 laurent22 merged commit f817c47 into laurent22:dev May 27, 2024
10 checks passed
@sysescool
Copy link
Contributor

nice! thanks a lot. so that I can use new diagram type block-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renderer About the note renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants