Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from an HTML rendered note to Markdown is missing a theme reset #7612

Closed
rodolf0 opened this issue Jan 11, 2023 · 6 comments
Closed
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@rodolf0
Copy link

rodolf0 commented Jan 11, 2023

I have multiple notes, some created from Web Clipper and imported as HTML, some created using markdown directly in Joplin App. When I switch to an HTML one and then back to a Markdown based one, there is state which is not cleaned up resulting in rendering issues. For example:

  • Background is left to whatever color the HTML note had once you switch to a Markdown based note.
  • Fonts look weird (I'm guessing they're not reset to Joplin's default font and instead use HTML page's one).
  • Note margins seem to be off too.

Environment

Joplin version: I'm currently seeing this in v2.9.17 but I believe also happened in v2.8.8.
Platform: Linux
OS specifics: Fedora 36, Gnome 42.2, Wayland.

Steps to reproduce

  1. Open a Markdown note in 'viewer' mode.
  2. Switch to an HTML note open in 'viewer' mode (as obtained from web clipper for example).
  3. Switch back to the Markdown note in step 1 also in 'viewer' mode.

You'll now notice the Markdown Note is rendered differently as if influenced by the HTML style.

Describe what you expected to happen

I'd expect each note to be independent. Style of one note should not influence the next note you open.

@rodolf0 rodolf0 added the bug It's a bug label Jan 11, 2023
@antoniopaolini
Copy link

antoniopaolini commented Jan 16, 2023

Same problem for me.

But I noted a "trick" to reset the style.

If I select two or more notes and then I return on one "normal" note the style is reset.

My system info

JOPLIN:

Joplin 2.9.17 (prod, win32)
Sinc. versione: 3
Profilo versione: 41
Portachiavi supportato: No
Revisione: a84a8e7

Windows

Edizione Windows 10 Pro
Versione 21H2
Data installazione: ‎03/‎05/‎2022
Build sistema operativo 19044.2486
Numero di serie 5CD203M8ZQ
Esperienza Windows Feature Experience Pack 120.2212.4190.0
anim

@Jp88Programmer
Copy link

i want to work on this issuse please assign me this issue

@roman-r-m
Copy link
Collaborator

We do not assign issues. Feel free to work on it.

@deepampriyadarshi
Copy link

This issue not only occurs while switching between HTML to .md notes, but also when switching between two HTML notes. This indicates that it might also happen in cases where there are 2 .md notes rendered using custom CSS. Awaiting your reviews @laurent22, @roman-r-m for the PR #7708

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Mar 3, 2023
@github-actions
Copy link
Contributor

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
5 participants