Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Too much space below markdown toolbar when autosuggestions are turned off #6805

Closed
personalizedrefrigerator opened this issue Sep 2, 2022 · 1 comment
Labels
bug It's a bug iOS mobile All mobile platforms

Comments

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Sep 2, 2022

Environment

Joplin version: e40d733
Platform: Mobile
OS specifics: iOS 15.6.1

Steps to reproduce

  1. Disable auto-suggestions
  2. Enable the beta editor
  3. Edit a note
  4. Show the keyboard

screenshot of the markdown toolbar

Describe what you expected to happen

The markdown toolbar should be just above the keyboard, like it is on Android.

Possible solution

  • Add a setting to enable/disable additional space below the toolbar
    • In the markdown toolbar PR, it was observed that some iOS devices have keyboards that overlap the toolbar. My phone appears to be the opposite -- the toolbar, even without the additional padding, is well above the keyboard.
  • Wrap the toolbar in a KeyboardAvoidingView -- this seems to have the same issue as manually adding padding. Regardless, the screen is already wrapped in a KeyboardAvoidingView.
  • Wrap the toolbar in an InputAccessoryView. We're using a WebView to edit text. As such, it seems that we can't use an InputAccessoryView because it requires an inputAccessoryViewID property.
  • Make the markdown toolbar draggable -- moving it up/down when the keyboard is visible adjusts the space below it.
  • Move the markdown toolbar to the top of the screen.
@personalizedrefrigerator personalizedrefrigerator added the bug It's a bug label Sep 2, 2022
@personalizedrefrigerator
Copy link
Collaborator Author

On my device, I’m also noticing this when I do have the predictive text toolbar enabled:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug iOS mobile All mobile platforms
Projects
None yet
2 participants