Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gap on top of mobile app #2694

Closed
laurent22 opened this issue Mar 8, 2020 · 16 comments
Closed

Fix gap on top of mobile app #2694

laurent22 opened this issue Mar 8, 2020 · 16 comments
Labels
bug It's a bug high High priority issues mobile All mobile platforms

Comments

@laurent22
Copy link
Owner

It doesn't seem to always happen. Maybe just with dark theme?

The screenshot below is from Android.

image

@laurent22 laurent22 added bug It's a bug mobile All mobile platforms high High priority issues labels Mar 8, 2020
@DeadManIV
Copy link

DeadManIV commented Mar 8, 2020

Yeah that's the UI issue I mentioned in my thread here: https://discourse.joplinapp.org/t/android-app-constant-crashes-after-sync-setup/6633/6

For me, the bar/gap is always there. Light or dark theme. It's just white in the light theme, then half white (as in your screenshot) in the dark theme. But yeah the bar is always there. It wasn't in version 316, but every version after 316 had this issue. So something that changed there caused this. I've installed all versions after 316 trying to see if it fixed that issue in my thread (which was my fault).

@laurent22
Copy link
Owner Author

@DeadManIV, it doesn't happen on my device. What is the screen resolution on your device?

@laurent22
Copy link
Owner Author

Does your device has a notch by any chance? There's some new logic to add a gap if the device has a notch, but obviously it shouldn't do that. Or perhaps the logic to detect notch is faulty.

@DeadManIV
Copy link

I believe my resolution is 1080p. But yeah it does have a notch. That might indeed be the cause of the issue.
I have a OnePlus 6.

@ev-w
Copy link

ev-w commented Mar 8, 2020

207834E6-5BD2-4ED1-831F-FA4EEBD41BC1

Same issue here on iPhone 11 Pro Max

@JefferyT51
Copy link

JefferyT51 commented Mar 8, 2020

Ditto here on the iPhone X. iOS 13.3.1. Happens in "Dark" and "OLED Dark" themes.

Joplin-iOS-DarkMode-Bugged-1
Joplin-iOS-DarkMode-Bugged-3
Joplin-iOS-DarkMode-Bugged-2

@DeadManIV
Copy link

@JefferyT51 @ev-w Do you guys have this issue within notes as well? Using the new OLED dark mode theme? If that's available on iOS. Version 1.0.320
#2695

@ev-w
Copy link

ev-w commented Mar 8, 2020

@DeadManIV yes, the images @JefferyT51 posted above mirror my experience; the white part moves to the left side in a note view

@DeadManIV
Copy link

@DeadManIV yes, the images @JefferyT51 posted above mirror my experience; the white part moves to the left side in a note view

Ah no, I meant the issue I linked. Sorry for the confusion. This issue: #2695

@uavana
Copy link

uavana commented Mar 9, 2020

Also got a gap on Android Version with notch
Screenshot_20200309-130151

@foxmask
Copy link
Contributor

foxmask commented Mar 9, 2020

same as @uavana

@axq
Copy link
Contributor

axq commented Mar 9, 2020

No notch no gap for me on Android.

@ethan42411
Copy link
Contributor

Same issue on iPhone XR.
A6646B35-FCB0-4086-98C7-8AE19BBC0ECE

@coderrsid
Copy link
Contributor

Hey @laurent22, why you closed this issue? I was thinking of working on it.

@laurent22
Copy link
Owner Author

@coderrsid, this is my fix b367955, but I'm not sure it's correct at all, so if you can find a better solution and especially test on a device with a notch, it would still be worth it

@serenitatis
Copy link
Contributor

I have same issue on my Xiaomi Mi 9.

@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug high High priority issues mobile All mobile platforms
Projects
None yet
Development

No branches or pull requests

10 participants