-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gap on top of mobile app #2694
Comments
Yeah that's the UI issue I mentioned in my thread here: https://discourse.joplinapp.org/t/android-app-constant-crashes-after-sync-setup/6633/6 For me, the bar/gap is always there. Light or dark theme. It's just white in the light theme, then half white (as in your screenshot) in the dark theme. But yeah the bar is always there. It wasn't in version 316, but every version after 316 had this issue. So something that changed there caused this. I've installed all versions after 316 trying to see if it fixed that issue in my thread (which was my fault). |
@DeadManIV, it doesn't happen on my device. What is the screen resolution on your device? |
Does your device has a notch by any chance? There's some new logic to add a gap if the device has a notch, but obviously it shouldn't do that. Or perhaps the logic to detect notch is faulty. |
I believe my resolution is 1080p. But yeah it does have a notch. That might indeed be the cause of the issue. |
@JefferyT51 @ev-w Do you guys have this issue within notes as well? Using the new OLED dark mode theme? If that's available on iOS. Version 1.0.320 |
@DeadManIV yes, the images @JefferyT51 posted above mirror my experience; the white part moves to the left side in a note view |
Ah no, I meant the issue I linked. Sorry for the confusion. This issue: #2695 |
same as @uavana |
No notch no gap for me on Android. |
Hey @laurent22, why you closed this issue? I was thinking of working on it. |
@coderrsid, this is my fix b367955, but I'm not sure it's correct at all, so if you can find a better solution and especially test on a device with a notch, it would still be worth it |
I have same issue on my Xiaomi Mi 9. |
It doesn't seem to always happen. Maybe just with dark theme?
The screenshot below is from Android.
The text was updated successfully, but these errors were encountered: