Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a conflict when remote note has been deleted and local has been modified #10611

Open
laurent22 opened this issue Jun 17, 2024 · 0 comments
Labels
bug It's a bug desktop All desktop platforms high High priority issues sync sync related issue

Comments

@laurent22
Copy link
Owner

laurent22 commented Jun 17, 2024

Operating system

Windows

Joplin version

3.0.0

Desktop version info

No response

Current behaviour

When a remote note is deleted and the local one has been modified, we currently create a copy of the local note to the Conflict folder, and delete the local note. Strictly speaking this is probably the correct approach, however it can cause issues that are hard to resolve when users delete large number of notes on various devices, move them around to other folder, and other large operations.

This can result in many notes ending up in the Conflict folder in a flat hierarchy and then it's difficult to understand what happened and how to resolve the conflict.

Instead when the remote note has been deleted, and the local one has been modified, we should simply ignore the remote deletion. It means the user may end up with a note that they wanted to delete but it's easy to fix by deleting it again, and will cause less troubles than unwanted conflicts.

Expected behaviour

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues sync sync related issue
Projects
None yet
Development

No branches or pull requests

1 participant