Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old.reddit pages are not saved correctly as HTML by the Web Clipper #10274

Closed
laurent22 opened this issue Apr 6, 2024 · 4 comments
Closed

old.reddit pages are not saved correctly as HTML by the Web Clipper #10274

laurent22 opened this issue Apr 6, 2024 · 4 comments
Assignees
Labels
bug It's a bug clipper Anything that concerns the Web Clipper high High priority issues

Comments

@laurent22
Copy link
Owner

Ref: https://discourse.joplinapp.org/t/support-for-singlefile/37407

=> Open the RTE: All comments are missing

=> Open the Markdown viewer: formatting is better but all comments are missing too

They are actually in the HTML but for some reason are hidden by default, so maybe the CSS or something else needs to be tweaked.

@laurent22 laurent22 added bug It's a bug clipper Anything that concerns the Web Clipper high High priority issues labels Apr 6, 2024
@DarkFalc0n
Copy link
Contributor

I copy pasted the html output from Joplin to a seperate HTML file and it seems to be working fine in Chromium based browsers. It may as well be a limitation of the markdown viewer.

@Aitchessbee
Copy link

I also noticed that switching to rich text editor and, making some text change, then switching back to markdown editor caused the comments to disappear from the HTML code.

@laurent22 laurent22 self-assigned this Apr 15, 2024
@DarkFalc0n
Copy link
Contributor

DarkFalc0n commented Apr 15, 2024

This is related to <form> tag, that doesn't render in markdown. All comments are wrapped in <form> tags and hence invisible. I tried to work on this but the dev web clipper extension throws an error like this:

"error":"Internal Server Error: Cannot create property 'httpCode' on string 'Image at /home/darkfalcon/.config/joplin-desktop/tmp/pixel_dde73b08250645e98d0f25e3b7f40a27.png failed to load.'

However, a straightforward fix would be to replace all <form> with something else that renders properly in markdown.

@silversheaf
Copy link

silversheaf commented Jun 16, 2024

Hi -- was just wondering why this was marked completed? The problem still seems to be happening (I have the latest version)... @laurent22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug clipper Anything that concerns the Web Clipper high High priority issues
Projects
None yet
Development

No branches or pull requests

4 participants