Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

홈페이지 기여자 표시 추가 #15

Open
kkame opened this issue Jul 7, 2019 · 8 comments
Open

홈페이지 기여자 표시 추가 #15

kkame opened this issue Jul 7, 2019 · 8 comments

Comments

@kkame
Copy link
Member

kkame commented Jul 7, 2019

홈페이지 첫화면에 나오는 기여자 목록을
홈페이지 기여자와 번역 기여자로 분할 후 홈페이지 기여자 표시 추가

@14km
Copy link
Contributor

14km commented Jul 9, 2019

  • 테스트 작성
  • 기존 기여자 목록을 가져오는 소스의 잘못된 점 개선 + 테스트 작성
    => 일부 모바일 버전에서 사용시 정상적으로 노출되지 않는 문제가 있음

@kkame
Copy link
Member Author

kkame commented Jul 12, 2019

@all-contributors please add @kkame for code

@allcontributors
Copy link
Contributor

@kkame

I've put up a pull request to add @kkame! 🎉

@kkame
Copy link
Member Author

kkame commented Jul 12, 2019

@all-contributors please add @findstar for code

@allcontributors
Copy link
Contributor

@kkame

I've put up a pull request to add @findstar! 🎉

@kkame
Copy link
Member Author

kkame commented Jul 12, 2019

@all-contributors please add @K-Connor for code

@allcontributors
Copy link
Contributor

@kkame

I've put up a pull request to add @K-Connor! 🎉

@kkame
Copy link
Member Author

kkame commented Jul 13, 2019

기여자 섹션을 구분하는 것보다는 두개의 레포지터리에서 json파일을 가져온 후 하나의 영역에서 이모지로 구분하여 표시

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants