Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Tailwind 2 #488

Merged
merged 6 commits into from
Nov 26, 2020
Merged

[2.x] Tailwind 2 #488

merged 6 commits into from
Nov 26, 2020

Conversation

themsaid
Copy link
Member

This PR upgrades Jetstream stacks to use Tailwindcss v2

@miguilimzero
Copy link
Contributor

I think you forgot to remove the @tailwindcss/ui plugin for the livewire stack, which is no longer needed in TailwindCSS 2.

src/Console/InstallCommand.php - Line 117

@themsaid
Copy link
Member Author

@SrDante removed. thanks

@bonzai
Copy link
Contributor

bonzai commented Nov 25, 2020

I would create a new Checkbox component (like Input), because there is a lot of duplicated code.

@taylorotwell
Copy link
Member

I agree it may be nice to make a Checkbox component now. @themsaid can you look into that?

@NeptuneDesign
Copy link

NeptuneDesign commented Nov 25, 2020

Why not use the Input component, for example : <x-input type="checkbox" />

It would be necessary to adapt the Input component to take into account the checkbox and radio types.

@themsaid
Copy link
Member Author

Added a new checkbox component to the inertia and livewire stacks

@driesvints driesvints changed the title [2.0] Tailwind 2 [2.x] Tailwind 2 Nov 26, 2020
@richardkeep
Copy link
Contributor

@themsaid The Select input too is very necessary

@themsaid
Copy link
Member Author

@richardkeep The purpose of this PR is to upgrade to Tailwind2. Feel free to open PRs with other features/refactoring.

@mubashariqbal
Copy link

I believe the checkbox/input are missing the "border" utility class. As the code stands the border color applied has no affect.

https://play.tailwindcss.com/Q0vDJ0FloH

@bonzai
Copy link
Contributor

bonzai commented Nov 26, 2020

@mubashariqbal Your example is invalid because you didn't define the type attribute and plugins section in the config doesn't include @tailwindcss/forms package:

Zrzut ekranu 2020-11-26 o 15 09 03

@mubashariqbal
Copy link

Thanks, updated but adding had no affect: https://play.tailwindcss.com/J80flR1s2q

@NeptuneDesign
Copy link

https://play.tailwindcss.com/bmMQ6sUz8H

@bonzai
Copy link
Contributor

bonzai commented Nov 26, 2020

You forgot about the type attribute (it's required):

Zrzut ekranu 2020-11-26 o 15 14 53

@mubashariqbal
Copy link

I see, got it, thanks!

@taylorotwell taylorotwell merged commit e6055bb into master Nov 26, 2020
@driesvints driesvints deleted the tailwind2 branch November 26, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants