Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish Http\Livewire #87

Closed
jpkontreras opened this issue Sep 7, 2020 · 5 comments
Closed

publish Http\Livewire #87

jpkontreras opened this issue Sep 7, 2020 · 5 comments

Comments

@jpkontreras
Copy link

please

@calebporzio
Copy link
Contributor

@jpkontreras, please expound on the reasons you would want this published.

What specific customizations are you looking for?

I don't have control over this package, but I am both curious, AND want your issue to be a good place to have this discussion.

@imClement
Copy link
Contributor

Hello @calebporzio .

Here is what I would customize in Http/Livewire if it were accessible to me:

  1. I will add custom fields for Team model in vendor/laravel/jetstream/src/Http/Livewire/UpdateTeamNameForm.php
    as discussed in this PR [livewire][teams]Update state property to include custom team fields #72
    (thank you for your solutions)

  2. I will apply the same approach in vendor/laravel/jetstream/src/Http/Livewire/UpdateProfileInformationForm.php
    As commented in the PR above [livewire][teams]Update state property to include custom team fields #72 (comment) , this file currently add the entire User info toArray()

  3. I will add some custom $this->emit('teamUpdated'); that I need to use in some sibling components.

This is because I show the current team name in the header (livewire component) for easier orientation of the user and I need that component to refresh when the name of the current team is updated.

@imClement
Copy link
Contributor

imClement commented Sep 8, 2020

And one more thing that I would do is to implement real-time validation for some of the fields.

  1. For example, I need to have unique team names and also I need to make some verification against team_type (another custom field we have to use)

This also can be achieved by extending the livewire component as you advised here #72 (comment).
But having them accessible in Http\Livewire will be simpler.

@driesvints
Copy link
Member

This is a feature request. Feel free to attempt to PR something.

@jpkontreras
Copy link
Author

Hi @calebporzio
Answering to your question, nothing in particular i want to see the implementation and update if i need it.
Also i believe that if there is a piece that is being published(views) why the others are not?.

Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants