Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for macro in InstallCommand like UICommand in laravel/ui #407

Closed
Kamona-WD opened this issue Oct 28, 2020 · 1 comment
Closed

Comments

@Kamona-WD
Copy link

I would like to suggest to add checking for macro in install command this will make us be able to make packages
to add more stacks like in laravel ui we can make more presets
I mean some think like this in handle method in InstallCommand class

    if (static::hasMacro($this->argument('stack'))) {
        return call_user_func(static::$macros[$this->argument('stack')], $this);
    }

    // Install Stack...
    if ($this->argument('stack') === 'livewire') {
        $this->installLivewireStack();
    } elseif ($this->argument('stack') === 'inertia') {
        $this->installInertiaStack();
    }

And finally I'm sorry for my bad English

@bonzai
Copy link
Contributor

bonzai commented Oct 28, 2020

See #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants