Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "ml-*" to "mx-*" whenever possible for better support for both LTR/RTL languages, and avoid text-align attributes #363

Closed
MuhammedAlkhudiry opened this issue Oct 19, 2020 · 1 comment

Comments

@MuhammedAlkhudiry
Copy link

  • Jetstream Version: 1.4.0
  • Jetstream Stack: Inertia / Livewire
  • Laravel Version: 8.0.0
  • PHP Version: 7.4.0
  • Database Driver & Version:
    mysql

Description:

In the default views, there are many uses of "ml-" for spacing between elements that can be replaced safely to "mx-" which better since it has the same effect for both "direction: rtl" and "direction: ltr"

The same can be said for padding.

Also, text-align should be avoided whenever possible, since the direction style can take care of the text direction.
Example:

لقطة الشاشة 2020-10-19 133253

  • Using "text-left" caused a problem for "logout" when using "direction: rtl", although "profile" is working without text-align

Steps To Reproduce:

Any fresh installment of Jetstream with either Inertia/Livewire.

@driesvints
Copy link
Member

Feel free to send in a PR. I'm personally not sure this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants