Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for password before enable/disable 2FA #17

Closed
zaherg opened this issue Sep 2, 2020 · 2 comments
Closed

Ask for password before enable/disable 2FA #17

zaherg opened this issue Sep 2, 2020 · 2 comments

Comments

@zaherg
Copy link

zaherg commented Sep 2, 2020 •
edited
Loading

Hey,

Since the user might login from multiple devices, it would be better to protect the ability to enable/disable (and for sure generating new recovery code) something like

  1. Just the enable/disable https://d.pr/v/itaIyQ
  2. All buttons require confirmation https://d.pr/v/hrQW5R

I can submit a Draft PR with the code I added/changed to be reviewed and edited as required.

Thanks
@zaherg zaherg mentioned this issue Sep 2, 2020
Closed
@taylorotwell
Copy link
Member

Closing as this is a feature request.

@zaherg
Copy link
Author

zaherg commented Sep 2, 2020

hey @taylorotwell can I have your thoughts about this #20

@jtolj jtolj mentioned this issue Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zaherg @taylorotwell