Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabled interactivity for the database migration prompt. #1465

Closed
artshade opened this issue Mar 31, 2024 · 2 comments
Closed

Support disabled interactivity for the database migration prompt. #1465

artshade opened this issue Mar 31, 2024 · 2 comments

Comments

@artshade
Copy link

artshade commented Mar 31, 2024

Dear Developers,

Thank you for the incredibly marvelous project...

May I ask regarding the migration confirmation prompt. The prompt seems to be activated even with --no-intraction option set, and when $input->isInteractive() returns false.

The issue is that this is the single and only prompt with laravel new --no-interactive --database mysql #... command executed from the installer package.

I believe that an explicit disablement of interactivity means all default choices to be set automatically, and the default for the prompt mentioned, even if it can be destructive, may assume yes (as it does right now) and be considered adequate. Though, a warning in docs or during an execution should not make it worse.

What do you think if the confirm could be disabled if $input->isInteractive() returns false, and continue assuming it's confirmed by default, or well, additional option like --migrate ^^?

Best and kind regards

@driesvints
Copy link
Member

I ran laravel new test-prompts --no-interaction --database mysql and no prompt was activated. It just ran everything as expected. I'm on the latest v5.7.0 version of the installer.

@artshade
Copy link
Author

artshade commented Apr 2, 2024

I ran laravel new test-prompts --no-interaction --database mysql and no prompt was activated. It just ran everything as expected. I'm on the latest v5.7.0 version of the installer.

I am sorry, but it seems you missed the --jet option I probably missed to explicitly state, too. I assumed it by default, since it's the reason why I started it in this repo and not at Laravel Installer. Please try again with --jet option, since it's the Jetstream logic causes it it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants