Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2FA] Disabling and enabling two factor authentication should require the user's password. #143

Closed
DarthShmev opened this issue Sep 10, 2020 · 2 comments

Comments

@DarthShmev
Copy link
Contributor

In order to enable or disable 2FA, a user should be required to input their password via a confirmation modal. This will prevent a user from accidentally enabling 2FA and not setting it up. Also, the user's password should be required to disable 2FA in order to prevent potential hijacking of an account.

My proposal is to have a similar flow as to logging out other sessions.
Screen Shot 2020-09-10 at 5 18 38 PM

As always, feedback is welcome.

@yoeriboven
Copy link

It's probably better to actually enter the 6 digit code so we're sure 2FA is set up on the user's phone.

Also, this looks similar to #74.

@driesvints
Copy link
Member

Duplicate for #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants